This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR preprocessor/6489
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Zack Weinberg <zack at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>
- Cc: "neil at daikokuya dot demon dot co dot uk" <neil at daikokuya dot demon dot co dot uk>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 30 Apr 2002 11:05:34 -0700
- Subject: Re: [PATCH] Fix PR preprocessor/6489
- References: <20020430162510.R32482@sunsite.ms.mff.cuni.cz><20020430175853.GA26266@codesourcery.com>
--On Tuesday, April 30, 2002 10:58:53 AM -0700 Zack Weinberg
<zack@codesourcery.com> wrote:
> On Tue, Apr 30, 2002 at 04:25:10PM +0200, Jakub Jelinek wrote:
>> Hi!
>>
>> The following patch fixes PR preprocessor/6489 (a regression from
>> 2.95.x).
>> # include <filename>
>> would result in
>> # include expects "fname" or <fname>
>> error. I don't think it is necessary to add much more for '\r', on all
>> stuff I've tried but this one egcs 1.1.2 and gcc 2.95.4 handled '\r'
>> characters equally bad as tradcpp.
>> Ok to commit?
>
> For mainline, I would prefer patches to make tradcpp universally
> accept \r\n, \r, \n\r as line endings; it's silly that it doesn't
> match the behavior of normal cpp.
>
> For the branch, your patch should at least cope with bare \r as line
> ending, as well as \r\n and \n.
Thanks for reviewing.
Jakub, this is OK for the branch, then.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com