This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc 3.1 bug: flag_no_inline incorrectly set
- From: "David S. Miller" <davem at redhat dot com>
- To: anton at samba dot org
- Cc: gcc-bugs at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
- Date: Sat, 27 Apr 2002 22:52:35 -0700 (PDT)
- Subject: Re: gcc 3.1 bug: flag_no_inline incorrectly set
- References: <20020428054450.GA17500@krispykreme>
From: Anton Blanchard <anton@samba.org>
Date: Sun, 28 Apr 2002 15:44:51 +1000
I was chasing down why -Winline doesnt work with gcc 3.1 and noticed
that we were always setting flag_no_inline. With some help from
Alan Modra, we narrowed it down to c_common_post_options where
the check for flag_instrument_function_entry_exit looks backwards.
...
This change looks correct, and I recommend that it be approved for
both the mainline and 3.1 branch.
Mark?
Anton, could you cook up the appropriate ChangeLog entry?
Please always do this in the future for changes that you submit.
Thanks.
--- gcc_3_1_orig/gcc/c-common.c Sun Apr 28 15:26:13 2002
+++ gcc_3_1/gcc/c-common.c Sun Apr 28 14:51:27 2002
@@ -4134,7 +4133,7 @@
/* Use tree inlining if possible. Function instrumentation is only
done in the RTL level, so we disable tree inlining. */
- if (! flag_instrument_function_entry_exit)
+ if (flag_instrument_function_entry_exit)
{
if (!flag_no_inline)
flag_no_inline = 1;