This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: rs6000 ABI_AIX -fpic
On Sun, Apr 21, 2002 at 07:23:36PM -0700, David S. Miller wrote:
> From: David Edelsohn <dje@watson.ibm.com>
> Date: Sun, 21 Apr 2002 22:29:05 -0400
>
> As we prepare for the GCC 3.1 release, we need to be much more
> careful with last minute patches to ensure that they do not cause
> unintended regressions. And problems not addressed in GCC 3.1.0 always
> can be fixed in the GCC 3.1.1 update.
>
> I agree with David here, you should have waited for one of the
> port maintainers to review your change before installing it and
> this is especially important now.
What then constitutes an obvious patch?
I acted out of concern for the 3.1 release quality, and had sent David
an email describing the bug, with obvious fix, some 17.5 hours before
making the commit. As far as I knew, he hadn't received the email and
wouldn't have time to apply the change before Mark cut the pre-release.
--
Alan Modra
IBM OzLabs - Linux Technology Centre