This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: rs6000 ABI_AIX -fpic


On Sun, Apr 21, 2002 at 09:09:35PM -0400, David Edelsohn wrote:
> >>>>> Alan Modra writes:
> 
> Alan> Committed as obvious, to fix 2002-03-19 change on mainline and branch.
> 
> Alan,
> 
> 	Please do not check in patches on a release branch without the
> approval of the appropriate MAINTAINER, especially on the eve of a
> release.

"especially on the eve of a release" is why I went ahead and made the
change.  I suppose according to the rules I should have reverted your
2002-03-19 change.  Would that have been better?

Leaving flag_pic set broke powerpc64-linux glibc builds by causing
linuxthreads/crti.o:_init (-fpic in makefile) to have a different
stack frame to csu/crti.o:_init (-fpic had been removed by someone
who disliked the old -fpic warnings).  The bogus flag_pic may well
cause more trouble than just messing up stack frames;  I didn't
check for further breakage.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]