This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Builtins and C++ and such (take 3)
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: Mark Mitchell <mark at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
- Date: Sun, 31 Mar 2002 21:04:29 -0800 (PST)
- Subject: Re: [PATCH] Builtins and C++ and such (take 3)
> > I'm going to apply your patch with that change, test it, and then
> > check it in.
Mark. It's been three days now, so excuse me for being a bit testy.
Did you test this patch? How? It causes regressions in the library
testsuite. What should be done?
Roger's patch fixes the library bugs, but then gives:
FAIL: g++.dg/inherit/template-as-base.C (test for excess errors)
FAIL: g++.benjamin/tem03.C caused compiler crash
FAIL: g++.benjamin/typedef01.C caused compiler crash
FAIL: g++.brendan/line1.C caused compiler crash
FAIL: g++.jason/crash7.C caused compiler crash
FAIL: g++.mike/net44.C caused compiler crash
FAIL: g++.other/typedef5.C caused compiler crash
So, no situation is ideal here. Can we have some forward movement here
within the next 24 hours or revert?
> I've just confirmed that it was changing this line to use COPY_DECL_RTL
> that introduced the three new regressions in the libstdc++-v3 test suite.
> g++'s tree inliner must require the "make_decl_rtl(NODE,NULL)" call
> in the expansion of DECL_RTL. The following patch, reverts Mark's change
> to my original patch (take 3), and should cure these regressions.
... it does, thanks. It also adds more g++ regressions.
-benjamin