Re: cpplib 3.2: Fast number lexing

[Zack Weinberg <zack at codesourcery dot com>]

On Thu, Mar 21, 2002 at 11:28:48PM +0000, Neil Booth wrote:
> Zack Weinberg wrote:-
> 
> > This looks good except for one thing:
> > 
> > > I moved a line of code so that GCC might be clever enough to merge the
> > > two calls to ht_lookup into one.
> > 
> > I think it would be better if you merged them in the source.  That
> > makes it obvious to a later reader that there isn't any difference
> > between the calls.
> 
> Two arguments are different, at the RHS.  So this would involve
> introducing two more local vars.  Is it worth it?

I missed the HT_ALLOCED vs. HT_ALLOC difference; you're right, it's
clearer the way it is.

(Maybe we should try to think of names for those flags that are a
little more visually distinct.)

zw