This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: cpplib 3.2: Fast number lexing
Zack Weinberg wrote:-
> This looks good except for one thing:
>
> > I moved a line of code so that GCC might be clever enough to merge the
> > two calls to ht_lookup into one.
>
> I think it would be better if you merged them in the source. That
> makes it obvious to a later reader that there isn't any difference
> between the calls.
Two arguments are different, at the RHS. So this would involve
introducing two more local vars. Is it worth it? Since they're at the
RHS, a smart compiler should be able to push the two args and jump to
common code to handle the rest, no?
Neil.