This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: GEN_INT_MODE v2


Lars Brinkhoff wrote:
> 
> Richard Henderson <rth@redhat.com> writes:
> > On Fri, Mar 15, 2002 at 10:53:14PM +0100, Lars Brinkhoff wrote:
> > > One reason to keep the all-upper-case name could be that programmers
> > > should think of it as a close relative of GEN_INT.  But I dunno.
> > That was my thought.  If there's objection, we can change it.  I
> > don't really care either way.
> 
> Neither do I, but I haven't seen any objections (other than Stan
> Shebs', if that counts).

I like to think I matter, at least a little bit. :-)

But seriously, although the coding standard doesn't actually say
whether functions should always be lower-case, I'd say it's implied
by "macros should be in ALL_CAPS when it's important to be aware
that it's a macro" (http://gcc.gnu.org/codingconventions.html).
In this case, we have something that's not even a macro anymore.

I'm piping up about this because it breaks the heuristic that
all_caps => macro.  One of these is maybe no big deal, just a
way to haze newbies, but it opens the possibility of having
hundreds more, at which everybody will have difficulties
remembering which is which.

Stan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]