This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Java: Fix double-evaluation of RHS of array store
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- To: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 11 Mar 2002 08:47:15 -0800 (PST)
- Subject: Re: Java: Fix double-evaluation of RHS of array store
- References: <3C8C9175.4040005@waitaki.otago.ac.nz>
- Reply-to: apbianco at redhat dot com
Bryce McKinlay writes:
> Rebuilt libjava and ran testsuite without regressions on PowerPC
> linux. I'm checking this in as an obvious fix.
Thank you.
Just a note: it looks like people these days are leaning towards
"explain what you do in the ChangeLog, explain why you're doing it in
the rest of the patch." (it's what the hacking rules are saying, but
I've seen more reviews trying to enforce them:)
> * parse.y (patch_assignment): Wrap the right-hand-side with a save_expr
* parse.y (patch_assignment): Wrap the right-hand-side with a
save_expr.
> to prevent it getting evaluated twice in the store checking case.
This should be a comment in the code, which it is. I'm just noticing,
it doesn't necessarily have to be changed.
Thanks,
./A