This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GCC 3.1 Issues


Jakub Jelinek <jakub@redhat.com> writes:

> On Fri, Mar 08, 2002 at 05:31:48PM +0100, Andreas Jaeger wrote:
>> Mark Mitchell <mark@codesourcery.com> writes:
>> 
>> > If you know of regressions in GCC 3.1 relative to previous releases,
>> > or major issues that stand between us and a GCC 3.0 release, please
>> > file PRs in GNATS and send the PR numbers to me.
>> 
>> I have two PRs that might be related:
>> - PR 5172: A miscompilation of glibc on i686, this is fixed if store
>>   motion is disable.
>> - PR 5200: Store motion is broken (the PR is a pointer to some
>>   messages so that this topic get reviewed before the 3.1 release).
>> 
>> Store motion seems to have some serious bugs (generating wrong code)
>> and if those are not getting fixed, I propose to disable store motion
>> completly.
>> 
>> Since store motion is a new feature relative to 3.0, any bugs in store
>> motion are regressions.
>
> Ok for branch then?

That's the obvious workaround.  I would prefer if somebody fixes store
motion correctly (but it might be that this cannot be done on the
release branch) - and if nobody likes to do this, we should consider
removing it again.

Andreas

> Bootstrapped and regtested on {i386,ia64}-redhat-linux.
>
> 2002-03-09  Jakub Jelinek  <jakub@redhat.com>
>
> 	PR optimization/5172, optimization/5200
> 	* gcse.c (gcse_main): Disable store_motion.
>
> --- gcc/gcse.c.jj	Tue Feb 19 11:13:09 2002
> +++ gcc/gcse.c	Sat Mar  9 21:01:54 2002
> @@ -903,7 +903,8 @@ gcse_main (f, file)
>    end_alias_analysis ();
>    allocate_reg_info (max_reg_num (), FALSE, FALSE);
>  
> -  if (!optimize_size && flag_gcse_sm)
> +  /* Store motion disabled until it is fixed.  */
> +  if (0 && !optimize_size && flag_gcse_sm)
>      store_motion ();
>    /* Record where pseudo-registers are set.  */
>    return run_jump_opt_after_gcse;
>
>
> 	Jakub
>

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]