This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] 3 tiny mklibgcc.in fixes
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Henderson <rth at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: 05 Mar 2002 13:24:56 -0300
- Subject: Re: [PATCH] 3 tiny mklibgcc.in fixes
- Organization: GCC Team, Red Hat
- References: <20020305121920.S2204@sunsite.ms.mff.cuni.cz>
On Mar 5, 2002, Jakub Jelinek <jakub@redhat.com> wrote:
> - if [ "@libgcc_visibility@" = yes ]; then
> + if [ "@libgcc_visibility@" = yes -a "$SHLIB_LINK" ]; then
Please don't use `-a' nor `"foo"' as `"foo" != ""'. It's more
portable to spell use && and spell out the != "" explicitly. I'd
rather see this written as:
if [ "@libgcc_visibility@" = yes ] && [ "x$SHLIB_LINK" != x ]; then
However, I see there are many other uses of `-a' and assumed != "" all
over this script, so I'll leave it to your own discretion to fix them
or not.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer