This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Followup patch (was Re: [C++ Patch] PR 4093)


On Tue, Feb 26, 2002 at 01:52:05PM +0000, Jason Merrill wrote:
> >>>>> "Richard" == Richard Henderson <rth@redhat.com> writes:
> > On Sun, Feb 24, 2002 at 06:23:06PM +0000, Jason Merrill wrote:
> >> You shouldn't be building the C++ frontend with HP's compiler ...
> 
> > Why don't we put 
> 
> > #ifndef __GNUC__
> > #error "you should be using make bootstrap"
> > #endif
> 
> > in cp-tree.h and be done with it?
> 
> I wouldn't object.

If one blanket-write-privs maintainer makes a suggestion, and a
second one states no objections, is that approval?  (Sounds awfully
philosophical... what is the sound of one maintainer clapping?)

Diff'd against mainline, tested by trying to build with -U__GNUC__ added
to the flags.

I found a missing prototype while doing this.  (I tried to build cp/init.c
for my test, which is what defines build_init, and this gave me the
"declaraction isn't a prototype" warning.  build_init is also (only?) used
in cp/except.c, so it's not static.)


2002-03-01  Phil Edwards  <pme@gcc.gnu.org>

	* cp-tree.h:  Require __GNUC__ to be #defined.
	(build_init):  Add missing prototype.


Index: cp-tree.h
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/gcc/cp/cp-tree.h,v
retrieving revision 1.682
diff -u -3 -p -r1.682 cp-tree.h
--- cp-tree.h	28 Feb 2002 07:39:37 -0000	1.682
+++ cp-tree.h	1 Mar 2002 06:45:47 -0000
@@ -28,6 +28,10 @@ Boston, MA 02111-1307, USA.  */
 #ifndef GCC_CP_TREE_H
 #define GCC_CP_TREE_H
 
+#ifndef __GNUC__
+#error "You should be using 'make bootstrap' -- see installation instructions"
+#endif
+
 #include "c-common.h"
 
 /* Usage of TREE_LANG_FLAG_?:
@@ -3900,6 +3904,7 @@ extern void init_init_processing		PARAMS
 extern void emit_base_init			PARAMS ((tree, tree));
 extern tree expand_member_init			PARAMS ((tree, tree, tree));
 extern tree build_aggr_init			PARAMS ((tree, tree, int));
+extern tree build_init				PARAMS ((tree, tree, int));
 extern int is_aggr_type				PARAMS ((tree, int));
 extern tree get_aggr_from_typedef		PARAMS ((tree, int));
 extern tree get_type_value			PARAMS ((tree));


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]