This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 252.eon


>>>>> "Paolo" == Paolo Carlini <pcarlini@unitus.it> writes:

> sorry for bothering you all... It looks like the following simple cp patch from
> Michael Matz is to date still unreviewed:

>     http://gcc.gnu.org/ml/gcc-patches/2002-02/msg01537.html

Thanks for the heads-up; I often don't notice patches without the word C++
in the subject.

It looks to me like the existing call to complete_type_or_else is useless;
a pointer type is always complete.  I'd suggest just removing that in favor
of the call to complete_type added by the patch.  Also, don't cast the
result to void.

With those changes, the patch is OK.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]