This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: 252.eon
- From: Jason Merrill <jason at redhat dot com>
- To: Paolo Carlini <pcarlini at unitus dot it>, matz at suse dot de
- Cc: gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com, aj at suse dot de
- Date: Thu, 28 Feb 2002 00:28:13 +0000
- Subject: Re: 252.eon
- References: <3C7D228D.61168E78@unitus.it>
>>>>> "Paolo" == Paolo Carlini <pcarlini@unitus.it> writes:
> sorry for bothering you all... It looks like the following simple cp patch from
> Michael Matz is to date still unreviewed:
> http://gcc.gnu.org/ml/gcc-patches/2002-02/msg01537.html
Thanks for the heads-up; I often don't notice patches without the word C++
in the subject.
It looks to me like the existing call to complete_type_or_else is useless;
a pointer type is always complete. I'd suggest just removing that in favor
of the call to complete_type added by the patch. Also, don't cast the
result to void.
With those changes, the patch is OK.
Jason