This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patches] Fix x86-64 code alignment
- From: Jan Hubicka <jh at suse dot cz>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org, patches at x86-64 dot org
- Date: Wed, 27 Feb 2002 11:05:44 +0100
- Subject: Re: [patches] Fix x86-64 code alignment
- References: <20020227093208.GA24297@atrey.karlin.mff.cuni.cz>
> Hi,
> This attached patch makes us to use p2align on x86-64 compiler.
> THis definition should probably be commonized to gas.h, but at the
> moment I don't have time to do so and I want to install it to 3.0 branch,
> where such cleanup is inacceptable, I guess.
>
> Honza
Hmm, not my day today. The x86-64.h defines that constant conditionally
already but configure script missdetect it on crosscompilation. I guess it is
easiest to just define it always. There is no assembler in existence alcking
this feature.
I am going to install the attached patch to mainline/x86-64/3.1 branch.
Wed Feb 27 11:03:45 CET 2002 Jan Hubicka <jh@suse.cz>
* x86-64.h (ASM_OUTPUT_MAX_SKIP_ALIGN): Allways define.
Index: x86-64.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/x86-64.h,v
retrieving revision 1.2.4.1
diff -c -3 -p -r1.2.4.1 x86-64.h
*** x86-64.h 2002/02/21 20:02:12 1.2.4.1
--- x86-64.h 2002/02/27 10:03:41
*************** Boston, MA 02111-1307, USA. */
*** 73,79 ****
This is used to align code labels according to Intel recommendations. */
- #ifdef HAVE_GAS_MAX_SKIP_P2ALIGN
#define ASM_OUTPUT_MAX_SKIP_ALIGN(FILE,LOG,MAX_SKIP) \
do { \
if ((LOG) != 0) { \
--- 73,78 ----
*************** Boston, MA 02111-1307, USA. */
*** 81,87 ****
else fprintf ((FILE), "\t.p2align %d,,%d\n", (LOG), (MAX_SKIP)); \
} \
} while (0)
- #endif
/* i386 System V Release 4 uses DWARF debugging info.
--- 80,85 ----