This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: or32 gcc port
- From: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- To: Damjan Lampret <lampret at opencores dot org>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 26 Feb 2002 09:43:21 +0000 (GMT)
- Subject: Re: Patch: or32 gcc port
On Tue, 26 Feb 2002, Damjan Lampret wrote:
> As per instructions on http://gcc.gnu.org/contribute.html# Submitting
> Patches, I submit or32 target patch for the OpenRISC 1000 architecture, OR32
> subset.
Please read the documentation in the internals manual, under "Anatomy of a
Target Back End", of the various components for a new target. You're
lacking the documentation.
> +#define FALSE 0
> +#define TRUE 1
These are defined in system.h, there's no need to define them in your
headers any more.
> +/* This describes the machine the compiler is hosted on. */
> +#define HOST_BITS_PER_CHAR 8
> +#define HOST_BITS_PER_SHORT 16
> +#define HOST_BITS_PER_INT 32
> +#define HOST_BITS_PER_LONG 32
These are determined by autoconf.
> +/* Arguments to use with `exit'. */
> +#define SUCCESS_EXIT_CODE 0
> +#define FATAL_EXIT_CODE 33
Why do you need these?
Zack did a lot of work to get rid of xm-* headers and x-* makefile
fragments. You need to provide detailed justification for everything in
the ones you're adding.
--
Joseph S. Myers
jsm28@cam.ac.uk