This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: fix fastjar -C


Anthony Green wrote:
> I'll use your patch, except...
> 
> 
>>+#if 0
>>+      ze = (zipentry*)xmalloc(sizeof(zipentry));
>>+      ze->mod_time = UNPACK_UB2(file_header, LOC_COMP);
>>+      ze->crc = UNPACK_UB4(cen_header, CEN_CRC);
>>+      ze->mod_time = UNPACK_UB2(cen_header, CEN_MODTIME);
>>+      ze->mod_date = UNPACK_UB2(cen_header, CEN_MODDATE);
>>+      ze->csize = UNPACK_UB4(cen_header, CEN_CSIZE);
>>+      ze->usize = UNPACK_UB4(cen_header, CEN_USIZE);
>>+      ze->offset = UNPACK_UB4(cen_header, CEN_OFFSET);
>>+      ze->compressed = UNPACK_UB2(cen_header, CEN_COMP) != 0;
>>+#endi
> 
> ...what's this?

I don't remember.  It could have been a leftover from when I
looked into implementing the 'u' option, which require first
building a table of existing entries.


>>+static void *
>>+xmalloc (size_t nbytes)
>>+{
>>
> 
> We're linking against libiberty already, so we probably don't need this.

Well, it's an old patch ...
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/per/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]