This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add check back to expmed.c


On Thu, 2002-02-21 at 02:07, Richard Henderson wrote:
> On Thu, Feb 21, 2002 at 12:52:01AM -0800, Eric Christopher wrote:
> > +                  if (GET_CODE (value1) != REG)
> > +                    value1 = copy_to_reg (value1);
> > +
> >  		value1 = simplify_gen_subreg (maxmode, value1,
> >  					      GET_MODE (value1), 0);
> 
> I'd prefer that you at least attempt to simplify first.  I.e.
> 
> 	tmp = simplify_subreg (maxmode, value1, mode, 0);
> 	if (! tmp)
> 	  tmp = simplify_gen_subreg (maxmode, force_reg (mode, value1),
> 				     mode, 0);
> 	value1 = tmp;

Do you mean in addition to my change? I can add that in no problem. If
you mean instead I'll check and see if that works :)

-eric

-- 
I will not use abbrev.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]