This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Fix more of 5132
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 28 Jan 2002 18:46:03 -0800
- Subject: Re: [C++ PATCH] Fix more of 5132
--On Monday, January 28, 2002 10:28:10 PM +0000 Nathan Sidwell
<nathan@codesourcery.com> wrote:
> Hi,
> this fixes more parts of PR 5132. It turns out that we need to be careful
> during instantiation too. The IDENTIFIERs in the constructor elts should
> not be looked up by build_expr_from_tree, but in digest_init, which
> requires that the type is instantiated at that point.
>
> built & tested on i686-pc-linux-gnu, ok?
>
> nathan
> --
> Dr Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
> LLC 'But that's a lie.' - 'Yes it is. What's your point?'
> nathan@codesourcery.com : http://www.cs.bris.ac.uk/~nathan/ :
> nathan@acm.org
+
+ if (!complete_type_or_else (strip_array_types (type), NULL_TREE))
+ return error_mark_node;
Why do you need the strip_array_types here? Doesn't
complete_type_or_else recurse on ARRAY_TYPEs anyhow?
With that change, the patch is OK.
Thanks,
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com