This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Small fix for the C front end


On Wed, Jan 23, 2002 at 11:18:03AM -0800, Mark Mitchell wrote:
> >
> >-  if (TREE_CODE (value) == ERROR_MARK)
> >+  if (TREE_CODE (value) == ERROR_MARK || TREE_CODE (type) == ERROR_MARK)
> >     return error_mark_node;
> 
> This is OK -- except that the convention is to test against
> error_mark_node, not check TREE_CODE.  (I know you didn't introduce
> that, but while you're here you might as well fix it.)

Ok.  I was being consistent with what was there.

Applied (this morning) with that change.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]