This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testcase] Alpha reload ICE


>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:

 > Ok to commit?
 > Richard, any ideas on what can be done about this?

 > 2001-12-18  Jakub Jelinek  <jakub@redhat.com>

 > 	* gcc.c-torture/20011218-1.c: New test.

 > --- gcc/testsuite/gcc.c-torture/20011218-1.c.jj	Thu Aug 30 22:30:55 2001
 > +++ gcc/testsuite/gcc.c-torture/20011218-1.c	Tue Dec 18 16:04:33 2001
 > @@ -0,0 +1,12 @@
 > +struct S {
 > +  int a, b;
 > +  void (*f) (long, int);
 > +};
 > +
 > +void foo (struct S *x)
 > +{
 > +  long c = x->a * 50;
 > +  c /= (long) x->b;
 > +  c *= (long) x->b;
 > +  x->f (c, 0);
 > +}

we shouldn't be adding failing test cases to the testsuite.  It's
better to come up with a fix and THEN add the test case along with it.

Aldy


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]