This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Conditionalize INO handling for VMS


    Please move the #ifdef block to the top of the file, just after all
    the #includes.

I think that would be much less clear given how local this is.  What you
propose makes sense if there are a bunch of them or if they are used in
multiple places in the file but when there's only one use and it's this sort
of detail, I think it's much easier to read if it's adjacent to its usage.

In the original patch, Doug had this right before the function, but I felt
even those was too far away given the locality here.

The other approach is to remove the macro altogether and just have the #ifdef
in the code.  Do you think that would be clearer?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]