This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Changes to gcc 3.x to invoke an external cpp
On Thu, Dec 06, 2001 at 10:28:45PM +0000, Neil Booth wrote:
> Now I've got a clearer idea what you need and what you're doing I'm
> not so against it, but it's not my call.
>
> However, I would suggest the following would get a better review:
>
> 1) Choosing a good name for the switch
>
> 2) Factoring out the common specs into a sub-spec, just like cc1_options
> is. Your original patch duplicates too many specs (e.g. compare
> the tradcpp part with what you did in gcc.c - all that's different is
> tradcpp), and specs are fragile enough as they are.
>
> 3) Full documentation. I don't think your patch had any.
Just for the record, I agree; I'd now have no objection to the
patch if these things were done.
zw