This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Minor tweak to function.c:keep_stack_depressed
- From: Richard Henderson <rth at redhat dot com>
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 5 Dec 2001 15:24:46 -0800
- Subject: Re: Minor tweak to function.c:keep_stack_depressed
- References: <10112052309.AA26405@vlsi1.ultra.nyu.edu>
On Wed, Dec 05, 2001 at 06:09:32PM -0500, Richard Kenner wrote:
> I think you should be using
>
> !REGNO_REG_SET_P (EXIT_BLOCK_PTR->global_live_at_start, i)
>
> rather than !FUNCTION_VALUE_REGNO_P. See mark_regs_live_at_end
> for the complete set of cases that need handling.
>
> Indeed, since it appears that mark_regs_live_at_end sets that, isn't
> it the case that the *only* thing I have to test is that condition, not
> even the other clauses of that "if"?
No, since that doesn't tell you fixed-ness, nor does it give you all
of call-used-ness, since we don't set live_at_end for call-saved registers
that we never use. We could, but it makes the debug dumps prettier
if we don't.
So you do still need the mode, fixed, and invalidated tests.
r~