This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch: vector_size attribute
- From: Richard Henderson <rth at redhat dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 4 Dec 2001 13:35:00 -0800
- Subject: Re: patch: vector_size attribute
- References: <1007498952.27051.14.camel@litecycle.cc.andrews.edu>
On Tue, Dec 04, 2001 at 12:49:12PM -0800, Aldy Hernandez wrote:
> + { "vector_size", 1, 1, true, false, false,
> + handle_vector_size_attribute },
This should be a type attribute, not a decl attribute.
Think about it -- this is not a property of 'foobar',
but a property of the type of foobar.
> + nunits = vecsize / (TYPE_PRECISION (TREE_TYPE (*node)) / 8);
s/8/BITS_PER_UNIT/
> + error ("No relevant vector mode found");
No caps. I think you need to describe the problem better too.
> + error ("No data type for mode `%s'", GET_MODE_NAME (new_mode));
No caps, and I think this and the previous should be diagnosed
the same for the user.
r~