This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libf2c: use -objectlist instead of convenience libraries


On Dec  3, 2001, Toon Moene <moene@knmi.nl> wrote:

> Alexandre wrote:
>> I had formerly suggested us to use libtool convenience libraries 
>> to avoid exceeding command-line length limitations of some OSs.  
>> Later on, it occurred to me that there was a simpler solution, 
>> using libtool's -objectlist.  I've finally found time to implement > it.

> Hmmm - I thought David Edelsohn suggested that ...

I thought I had suggested it to him.  Anyway, if it was David who
pointed it out, my apologies for claiming the idea was mine :-)

>> I have also removed the bogus install command I've just mentioned 
>> in a message posted to gcc@gcc.gnu.org.

> I added that install because before that libg2c.la and libg2c.so ended
> up in different directories, which led to the static library always be
> used.

That's because when linking a library, -rpath must specify where the
library is going to be installed.  I'm checking in the patch below,
that fixes this problem.

>> Tested on athlon-pc-linux-gnu.  Toon, ok to install?  Ok to 
>> back-port to 3.0 branch?

> It's OK with me for the trunk.  There's little to be gained by
> backporting it to 3.0, because we didn't generate a shared libg2c.so
> then.

Ah, sorry, I thought the original patch had been merged into the
branch too.


Index: libf2c/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* Makefile.in ($(LIBG2C)): Fix -rpath argument to libtool.

Index: libf2c/Makefile.in
--- libf2c/Makefile.in
+++ libf2c/Makefile.in
@@ -142,7 +142,7 @@
 $(LIBG2C): s-libi77 s-libf77 s-libu77 s-libe77
 	$(LIBTOOL) --mode=link $(CC) -o $@ \
 	  -version-info $(VERSION_MAJOR):$(VERSION_MINOR):$(VERSION_SUB) \
-	  -rpath $(prefix)/lib \
+	  -rpath $(libsubdir)/$(MULTISUBDIR) \
 	  -objectlist s-libe77 \
 	  -objectlist s-libf77 \
 	  -objectlist s-libi77 \

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]