This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: More message and diagnostic fixes


Hans-Peter Nilsson wrote:-

> > -      warning ("Specified -g option is invalid with -maout and -melinux");
> > +      warning ("-g option is invalid with -maout and -melinux");
> >        write_symbols = DBX_DEBUG;
> 
> That one wasn't a good change.  It's not simply "-g" that is
> invalid, but *that* particular -g* option.  Think "you can't
> have -gdwarf-2 with a.out, but -gdwarf-2 has many names".
> 
> Whatever change in wording that reflects that is pre-approved,
> or adding back "specified" if that makes sense.  (Not being a
> native speaker.)

Thanks for the correction.  I've not committed the patch yet, so I'll
adjust it before committing.  Now you've explained it; the existing
text was fine but could easily be misunderstood as redundant to casual
readers of the code.  But there's no need to be concise, so I'll make
it "that particular -g option ..." just like you did above.

Cheers,

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]