This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Minor fix to dwarf2asm.c
- From: Richard Henderson <rth at redhat dot com>
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 30 Nov 2001 13:21:27 -0800
- Subject: Re: Minor fix to dwarf2asm.c
- References: <10111301330.AA26771@vlsi1.ultra.nyu.edu>
On Fri, Nov 30, 2001 at 08:30:01AM -0500, Richard Kenner wrote:
> This fixes a problem with EH and Ada on i86 with -fPIC.
>
> Committed as obvious fix and safe because it handles a case that
> used to abort.
This is neither obvious nor correct. It is safe, I guess, but that's
rather beside the point.
You _really_ need to give a better description of the problem. Or in
this case, any description whatsoever. You have a very bad habit of
not documenting your patches, and it annoys me every time you do it.
>From the barest of commentary that you do add, "all others" sounds like
a catch-all exception filter, which is hardly unique to Ada, and has a
representation that does not contain const1_rtx. Therefore I have zero
confidence that you know what you're doing.
Please revert.
r~