This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: double max case labels in switch


On Sat, Nov 24, 2001 at 12:29:43PM -0500, law@redhat.com wrote:
>   > On Thu, Nov 22, 2001 at 08:58:30PM +1030, Alan Modra wrote:
>   > > 	(get_attr_length): Scale insn_lengths.
>   > 
>   > This doesn't seem right.  This is used by variable length insn
>   > processing, isn't it?  Which means that the constants set in
>   > the md file for branch lengths would break.
>   > 
>   > Seems better to just fix the backends in question to represent
>   > lengths in bytes.
> Richard is correct.  Lengths should be in bytes.

I'm not quite sure what you're getting at here.  Consider:

o  insn_lengths is private to final.c

o  the external interface, get_attr_length, still returns byte lengths.

o  INSNLEN_GCD can be set to 1 if a back-end uses numbers other than real
   instruction lengths for some reason.  (Presumably this could happen
   via ADJUST_INSN_LENGTH?)

Alan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]