This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Generalize tree-dumping infrastructure
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 Nov 2001 08:56:17 -0800
- Subject: Re: PATCH: Generalize tree-dumping infrastructure
> OK, here's a new version. To make the diff easier, this patch doesn't
> reflect the rename from c-dump to tree-dump, I'll do that when I check it
> in.
This version is OK for mainline. Please check it in. Thanks.
> Are all the #defines in langhooks-def.h neccessary? Wouldn't it be easier
> to maintain if we just defined LANG_HOOKS_INITIALIZER in a natural way,
> and in the front ends have a lang_hooks_initialize function which re-sets
> the entries for the functions that the language wants to override?
Yes, that would work. There's some benefit to getting the right values
in there at compile-time, in that there are no ordering issues (is this
set up before this?).
I think the current scheme is workable enough, and people are used to
it enough, that there's not much benefit in changing it.
Thanks,
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com