This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: altivec stack frame patches


On Tue, 2001-11-20 at 17:28, Richard Henderson wrote:

heh... i posted the wrong rev because it looks like all my local sources
have all these changes :).  neat..

now if i could just get cvs to work... gcc.gnu.org seems to be acting
up.


> On Thu, Nov 15, 2001 at 10:42:25AM -0500, Aldy Hernandez wrote:
> > +   if (TARGET_ALTIVEC_ABI)
> > +     {
> > +       info_ptr->vrsave_mask = compute_vrsave_mask ();
> > +       info_ptr->vrsave_size  = 4;
> 
> Um, shouldn't that be 
> 
> 	info_ptr->vrsave_size = info_ptr->vrsave_mask ? 4 : 0;
> 
> so that you don't allocate space when you aren't going to save it?
> 
> > +     if (info->vrsave_mask != 0 && ALTIVEC_REG_BIT (i) != 0)
> 
> Typo.
> 
> 	((info->vrsave_mask != 0 & ALTIVEC_REG_BIT (i)) != 0)
> 
> > + (define_insn "set_vrsave"
> > +   [(set (reg:SI 109)
> > + 	(unspec:SI [(match_operand:SI 0 "register_operand" "r")
> > + 		    (reg:SI 109)] 30))]
> > +   "TARGET_ALTIVEC"
> > +   "mtspr 256,%0"
> > +   [(set_attr "type" "altivec")])
> 
> This one's not needed anymore.
> 
> 
> r~
-- 
Aldy Hernandez			E-mail: aldyh@redhat.com
Professional Gypsy
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]