This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix -save-temps from clobbering input file@apple.com


Stan Shebs <shebs@apple.com> writes:

|> Andreas Schwab wrote:
|> > 
|> > Casts are bad if you can easily avoid them, since they can hide bugs.
|> > 
|> > |> Let's not get into a stylistic debate here.
|> > 
|> > Please read <http://gcc.gnu.org/codingconventions.html>, this is on-topic.
|> 
|> I must confess to being mystified as to what you're referring to.

The code as it is written does not comply to the formatting rules.  I
didn't want to imply that the use of the cast itself is covered in the
coding conventions.  Still, I think the cast should be avoided, since that
is _so_ easy and makes the code much cleaner.

Andreas.

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de				completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]