This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [patch] Fix a segfault in h8300 port.

To: law at redhat dot com
Subject: Re: [patch] Fix a segfault in h8300 port.
From: Neil Booth <neil at daikokuya dot demon dot co dot uk>
Date: Thu, 1 Nov 2001 00:09:09 +0000
Cc: Kazu Hirata <kazu at hxi dot com>, gcc-patches at gcc dot gnu dot org
References: <879EA880A0FED411996B00B0D0B082EC0D39BF@hxi_exch01.hxi.com> <27840.1004548746@localhost.localdomain>

law@redhat.com wrote:-

> But you have to pass the length including the terminator to
> ggc_alloc_string.  I assumed that's the underlying bug you're fixing
> (the old code didn't include the terminator in the length, which
> could potentially lead to a segfault).

The comment and code in stringpool.c clearly indicates that, if a
length is passed in, it shouldn't include the NUL.

Neil.

References:
- RE: [patch] Fix a segfault in h8300 port.
  - From: Kazu Hirata
- Re: [patch] Fix a segfault in h8300 port.
  - From: law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]