This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: add target_flags to gensupport.c
- To: geoffk at geoffk dot org
- Subject: Re: add target_flags to gensupport.c
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- Date: Wed, 24 Oct 01 06:26:11 EDT
- Cc: gcc-patches at gcc dot gnu dot org
It can't possibly make sense to be querying target_flags in gen*.
At the least, this needs a large comment explaining how it is correct,
both here and in rtl.c where the use occurs.
The comment here is exactly right: code in rtl.c (specifically
BIGGEST_ALIGNMENT in get_mode_alignment) can reference target_flags.
Since all we're using it for is printing alignments in RTL dumps, it's
very much a "don't care".
We've seen these sorts of references before, so I'd prefer to just make the
comment in gensupport.c generic and not try to flag every possible such
reference.