This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to fix powerpc-ibm-aix4.3.3.0 bootstrap
- To: John Wehle <john at feith dot com>
- Subject: Re: Patch to fix powerpc-ibm-aix4.3.3.0 bootstrap
- From: Zack Weinberg <zack at codesourcery dot com>
- Date: Sun, 7 Oct 2001 14:33:13 -0700
- Cc: rth at redhat dot com, gcc-patches at gcc dot gnu dot org
- References: <200110072049.f97Kn4l05391@jwlab.FEITH.COM>
On Sun, Oct 07, 2001 at 04:49:04PM -0400, John Wehle wrote:
> > Err.. note that ggc_strdup doesn't act like strdup, despite
> > the name. It will canonicalize the string via the stringpool.
>
> I realize that the comments for ggc_alloc_string says this and
> the actual code does this for certain strings (i.e. the empty
> string and digit strings), however I failed to see where the
> code is to handle the general case. I don't belive obstack_grow0
> does anything to prevent duplication.
It used to, but you're right, it doesn't anymore. I dimly remember
this being changed around the same time we started sharing the
identifier hash table between cc1 and cpplib.
zw