This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Patch installed for warning in concat.c

To: DJ Delorie <dj at redhat dot com>
Subject: Re: Patch installed for warning in concat.c
From: Alexandre Oliva <aoliva at redhat dot com>
Date: 30 Sep 2001 16:09:23 -0300
Cc: ghazi at caip dot rutgers dot edu, gcc-patches at gcc dot gnu dot org
Organization: GCC Team, Red Hat
References: <200109281532.LAA29763@caip.rutgers.edu><200109292336.f8TNafB22467@greed.delorie.com>

On Sep 29, 2001, DJ Delorie <dj@redhat.com> wrote:

>> recompiling concat.c.  Installed as obvious.
>> 
>> +#if HAVE_STDLIB_H

> Obvious but wrong.  You should use #ifdef here, not #if.

Autoconf has started recommending the use of `#if', so that if you
define HAVE_STDLIB_H to 0 (which is a perfectly reasonable thing to
do, if you ask me), you still get the right result.  Also, if you fail
to test for stdlib.h, the absence of a #define HAVE_STDLIB_H will make
#if and #ifdef equivalent.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

Follow-Ups:
- Re: Patch installed for warning in concat.c
  - From: DJ Delorie

References:
- Patch installed for warning in concat.c
  - From: Kaveh R. Ghazi
- Re: Patch installed for warning in concat.c
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]