This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [C++ PATCH] Fix 3986




--On Wednesday, September 05, 2001 07:31:31 PM +0100 Nathan Sidwell 
<nathan@codesourcery.com> wrote:

> Mark,
> this patch fixes 2.95 regression 3986 which is another bug caused by
> our unshared binfos. I'd forgotten about indirect primary bases when
> forcing the canonical binfo. Also I've moved setting the
> LOST_PRIMARY_BINFO_P flag into mark_primary_bases, which I think it better
> belongs.
>
> booted & tested on i686-pc-linux-gnu, ok for mainline & branch?

Yes -- but we desparately need some comments in there to try to explain
this mess.  Comments with specific examples indicating why we're doing
what we're doing in terms of some hierarchy would be helpful.  And
have I mentioned that I don't like either the ABI requirements here,
or the way we implement virtual inheritance with unshared binfos? :-)

Thanks,

-- 
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]