This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: What is Happening with g++.dg/opt/alias1.C?
On Wed, Aug 08, 2001 at 10:56:45AM +0100, Jason Merrill wrote:
> >>>>> "Jeffrey" == Jeffrey Oldham <oldham@codesourcery.com> writes:
>
> > For gcc 3.1, gcc/testsuite/g++.dg/opt/alias1.C was created today, but
> > I could not find any message sent to gcc-patches@gcc.gnu.org and no
> > entry in gcc/testsuite/ChangeLog. Did I miss them?
>
> You missed the message to gcc-patches, entitled "PATCH to get_alias_set".
> Unfortunately, the regression tester showed 19 new failures in the g77
> testsuite with the patch, so I reverted it until I could determine what the
> problem was. I didn't think to XFAIL the new test in the meantime, sorry.
Does not CVS's diff prepend a header before each file? Where is the
header for alias1.C? For my CVS, a new file's header looks like:
Index: NewField/DiffOps/FieldShiftEngine.h
===================================================================
RCS file: FieldShiftEngine.h
diff -N FieldShiftEngine.h
*** /dev/null Tue May 5 14:32:27 1998
--- FieldShiftEngine.h Fri Aug 3 13:55:57 2001
> I never add entries to the testsuite ChangeLog for new tests; it seems
> pointless. I asked Mark for his thoughts on the subject, and he concurs.
In my opinion, ChangeLog entries should list every code change and
this includes new test files. This makes them very useful to see all
recent code changes in a directory.
> > The cvs log file is:
>
> > ----------------------------
> > revision 1.2
> > date: 2001/08/07 12:54:10; author: jason; state: Exp; lines: +1 -1
> > oops
> > ----------------------------
> > revision 1.1
> > date: 2001/08/07 11:13:54; author: jason; state: Exp;
> > * alias.c (get_alias_set): Return a previously calculated
> > alias set for a VAR_DECL.
>
> > What do these entries mean?
>
> The 1.1 entry indicates the patch which fixes the testcase. The 1.2 entry
> is me fixing a syntax error in the dg-options line.
Perhaps future cvs log entries could list your more informative
explanations. It might help avoid receiving email from confused
people like me. :)
Thanks,
Jeffrey D. Oldham
oldham@codesourcery.com