This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Remove some accidental additions, fix darwin


At 08:46 01.08.2001, Daniel Berlin wrote:
>Cut and pasted too much originally, someone else pointed it out (I had
>thought something small had changed so that the cpu defaults were
>different for AIX and SYSV, but it was just my eyes playing tricks on
>me).
>
>Also adds a DOUBLE_INT_ASM_OP for darwin that is ".quad", given the
>assembler supports neither. Stan, correct me if i've done the reverse
>of what you wanted, I can't find the email from a few hours ago for
>some reason.
>
>I didn't think it was right to define it to nothing in rs6000.h, and
>then just have aix.h and sysv4.h #undef it, since it can't work as
>nothing, and you'd just get assembler errors that probably made no
>sense (unrecognized opcode or pseudo-op), or worse, none at all.
>
>Maybe i should define it to "You need to define DOUBLE_INT_ASM_OP" so
>it's quite clear what's wrong in the assembler output, rather than add
>a definition to darwin.h?
>
>Lastly, I removed the 4 defs that slipped in during a merge without my
>noticing that had been replaced by target functions.
>
>Someone should probably add an
>#ifdef FUNCTION_PROLOGUE
>#error "Don't define FUNCTION_PROLOGUE anymore!"
>#endif
>etc
>or something like it to target-def.h.
>
>In the process of removing this, I noticed that s390/linux.h also
>defines FUNCTION_PROLOGUE. Is this pointless as well?
>
>This bootstraps on powerpc-linux-gnu, i'm building all the other
>crosses right now.
>
>Assuming they all go okay, does the patch look okay?
>
>2001-08-01 Daniel Berlin <dan@cgsoftware.com>
>
>         * config/rs6000.h (FUNCTION_PROLOGUE): Deleted again.
>         (FUNCTION_EPILOGUE): Ditto.
>         (ASM_OPEN_PAREN): Ditto.
>         (ASM_CLOSE_PAREN): Ditto.
>         (CPP_CPU_SPEC): Move back here.
>         (ASM_CPU_SPEC): Move back here.
>         (ASM_DEFAULT_SPEC): Define to nothing.
>         (CPP_DEFAULT_SPEC): Define to nothing.
>
>         * config/aix.h (CPP_CPU_SPEC): Removed.
>         (ASM_CPU_SPEC): Removed.
>
>         * config/sysv4.h (CPP_CPU_SPEC): Removed.
>         (ASM_CPU_SPEC): Removed.
>
>         * config/darwin.h (DOUBLE_INT_ASM_OP): Define to ".quad",

There's more of it, you revived DEFAULT_VTABLE_THUNKS in linux.h and 
linux64.h, please delete them again.
Hmm, probably the powerpc-unknown-linux-gnulibc1 target description can die 
now in config.gcc too.

Franz.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]