Re: [ast-optimizer-branch] [patch]: SSA for trees

[Diego Novillo <dnovillo at redhat dot com>]

On Mon, 23 Jul 2001, Nathan Sidwell wrote:

> Diego Novillo wrote:
> 
> > Would it be OK to include it in the branch?  Although large, the
> > patch should not destabilize anything as it is only activated
> > when compiling with -ftree-ssa.
> 
> ok, but
> * it's full of fold marks - can you remove those? gcc is flat, and
>   they'd have to go some time - make it now.
>
Hmm, I didn't know this was a requirement.  I checked the coding
style and found no references to this.  I also noticed that the
fr30 port uses folding markers.  That's why I thought they would
be OK.

I'm not opposed to removing them, in principle.  But I do find
them useful.

> * the knr style parameter naming should be indented by 5
>
OK, thanks.

> * should we call these files ast-foo.c, rather than tree-foo.c?
>   tree-opt.h is a bad name (options or optimization), just ast.h
>   would be fine I think.
>
Sure.  Similarly, should we change the internal identifiers that
are now named tree_*?


> * optimize_tree is not a good name for an ssa specific optimization
> 
OK.  I'll think of a better name.


Diego.