This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Fastcall support, 3rd. try
Richard Henderson <rth@redhat.com> wrote
> The patch looks techinically fine; it'll have to wait for your
> gcc assignment to come through to be applied.
Thanks!
> I'd appreciate it if you wrote some tests for this, both testing
> caller and callee written in C, as well as one of caller or callee
> written in assembly. You'd put this in the gcc.dg subdirectory
> so that the test can be annotated to only apply to x86 with some
> appropriate windows flavour.
Of course I can write these tests. Unfortunately, these tests could not be
used right now even if they existed. The reason is that 'as' and 'dlltool'
need to be modified to accept/handle decorated fastcall labels properly. I
already submitted a patch to the binutils mailing-list.
I will write the tests and submit them in a separate patch. Is that okay?
> It's not that I don't believe that the patch works now, but that
> at some point in the future someone may accidentally break it.
Sure!
--
Eric Kohl
ekohl@rz-online.de