Re: 3 debug hooks for begin_function

[Geoff Keating <geoffk at geoffk dot org>]

Neil Booth <neil@daikokuya.demon.co.uk> writes:

> >  (3) Change debug_hooks->source_line to take the line number directly
> >      instead of via a note.  Notice _all_ versions just immediately
> >      grab the line number from the note and otherwise ignore it.
> 
> Sadly not - xcoffout.c's version uses RTX_INTEGRATED_P (note) --
> something to do with inlined functions -- which is why I'd left the
> rtx alone.  Is there an easy way to elide this?  e.g. maybe it always
> true or false, xcoffout shouldn't really care, or it is determinable
> some other way from xcoffout.c?  If not, we'll need to stick to the
> RTX or have an extra parameter.

I think what it's actually testing is "is this line before the first
line in the function".  Some part of the tools treats line numbers
relative to the first line in the function and is unhappy when
this is negative.   I never did really understand what was going on,
it might just be a cascading series of bugs.

-- 
- Geoffrey Keating <geoffk@geoffk.org>