This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix store motion, revised PRE memory handling
- To: law at redhat dot com
- Subject: Re: [PATCH] Fix store motion, revised PRE memory handling
- From: Richard Henderson <rth at redhat dot com>
- Date: Mon, 16 Jul 2001 11:03:00 -0700
- Cc: Daniel Berlin <dan at cgsoftware dot com>, gcc-patches at gcc dot gnu dot org
- References: <87u20cesr3.fsf@cgsoftware.com> <29502.995305727@localhost.localdomain>
On Mon, Jul 16, 2001 at 11:48:47AM -0600, law@redhat.com wrote:
> I'd like to see more discussion for the process_insert_insn change. It
> looks totally wrong to me. emit_move_insn should work just fine for
> memory operands as long as their addresses are valid. And the validity
> of a memory address should have been checked via the call to general_operand.
Indeed. And even supposing there's a good reason for the
change, nonmemory_operand would be the proper test.
r~