This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

XPasses in libstdc++ test suite



I do get on i686-linux-gnu these passes running the testsuite:
XPASS: g++.dg/vtgc1.C (test for excess errors)
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Multivv3, 0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*VTT for Multivv3, 0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Multiss2, vtable for Base2
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Multivs1, vtable for Base2
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*VTT for Multivs1, vtable for Base2
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Multisv0, vtable for Side0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*VTT for Multisv0, vtable for Side0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Side0, 0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for VbasedA, 0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*VTT for VbasedA, 0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Base2, vtable for Base1
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Base1, vtable for Base0
XPASS: g++.dg/vtgc1.C scan-assembler .vtable_inherit[   ]*vtable for Base0, 0

According to cvs log, these XFAILs were added with:
date: 2001/04/26 20:05:34;  author: mmitchel;  state: Exp;  lines: +14 -0
        * invoke.texi: Document more C++ command-line options.

        Remove support for -Wextern-inline, -flabels-ok, -fvtable-gc, -fxref
        * cp-tree.h (warn_extern_inline): Remove.
        (flag_labels_ok): Likewise.
        * decl2.c (warn_extern_inline): Remove.
        (flag_labels_ok): Likewise.
        (lang_f_options): Remove labels-ok, vtable-gc, xref.
        (unsupported_options): Add them.
        (cxx_decode_option): Don't accept -Wextern-inline.
        * method.c (hack_identifier): Remove -flabels-ok support.
        * spew.c (see_typename): Likewise.

        * g++.dg/vtgc1.C: XFAIL.


But later Jason re-added vtable-gc:
2001-05-21  Jason Merrill  <jason_merrill@redhat.com>

        * class.c (build_vtable_entry_ref): Lose vtbl parm.  Fix for new abi.
        (build_vtbl_ref): Adjust.
        (dfs_accumulate_vtbl_inits): Set TREE_CONSTANT on the vtable address.
        * decl2.c (lang_f_options): Remove huge-objects, vtable-thunks.
        Re-add vtable-gc.
        (unsupported_options): Correspondingly.

IMO it's time to revert Mark's patch and remove the XFAILs.

Ok to commit the appended patch?  I've tested it on i686-linux and it
now the XPASS are normal passes.

Andreas

2001-07-16  Andreas Jaeger  <aj@suse.de>

	* g++.dg/vtgc1.C: Revert patch from 2001-04-26 since vtable-gc is
	supported again.

Index: vtgc1.C
===================================================================
RCS file: /cvs/gcc/egcs/gcc/testsuite/g++.dg/vtgc1.C,v
retrieving revision 1.3
retrieving revision 1.2
diff -u -p -r1.3 -r1.2
--- vtgc1.C	2001/04/26 20:05:34	1.3
+++ vtgc1.C	2001/02/13 02:45:14	1.2
@@ -1,6 +1,5 @@
 // { dg-do compile }
 // { dg-options "-fvtable-gc" }
-// { dg-excess-errors "-fvtable-gc unsupported" { xfail *-*-* } }
 // Origin: Hans-Peter Nilsson <hp@bitrange.com>
 
 class Base0
@@ -119,29 +118,16 @@ void x3 (Multivs1 *ii) { ii->f2();}
 void x4 (Multiss2 *ii) { ii->f2();}
 void x5 (Multivv3 *ii) { ii->f2();}
 
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Multivv3, 0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*VTT for Multivv3, 0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Multiss2, vtable for Base2" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Multivs1, vtable for Base2" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*VTT for Multivs1, vtable for Base2" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Multisv0, vtable for Side0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*VTT for Multisv0, vtable for Side0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Side0, 0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for VbasedA, 0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*VTT for VbasedA, 0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Base2, vtable for Base1" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Base1, vtable for Base0" } }
-// { dg-final { setup_xfail *-*-* } }
 // { dg-final { scan-assembler-dem vtgc1.C "\.vtable_inherit\[ \t\]*vtable for Base0, 0" } }

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]