This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix, was: Re: [Fwd: CVS trunk bootstrap failure on alphaev6-unknown-linux-gnu]
- To: Toon Moene <toon at moene dot indiv dot nluug dot nl>
- Subject: Re: Fix, was: Re: [Fwd: CVS trunk bootstrap failure on alphaev6-unknown-linux-gnu]
- From: Alexandre Oliva <aoliva at redhat dot com>
- Date: 09 Jul 2001 12:01:56 -0300
- Cc: Joern Rennecke <amylaar at redhat dot com>, gcc-bugs at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Organization: GCC Team, Red Hat
- References: <200107062132.f66LW5Y07240@phal.cambridge.redhat.com><3B47062A.5D627786@moene.indiv.nluug.nl><orzoag1wul.fsf@guarana.lsd.ic.unicamp.br><3B4882B2.6833AB29@moene.indiv.nluug.nl>
On Jul 8, 2001, Toon Moene <toon@moene.indiv.nluug.nl> wrote:
> OK to install ?
I think it would still be a good idea to pass the mode as an argument,
just in case the two other arguments are CONST_INTs (remember that
CONST_INTs don't have a mode). In fact, your proposed patch would
probably crash or just fail to do right thing should the first
argument be a CONST_INT.
However, since all uses of these instructions take a register as an
argument (and only now, after having written the paragraph above, do I
see it can only make sense to call have_add2_insn having a REG in the
first argument, I think it may indeed be ok. Then perhaps it would be
enough to check that GET_MODE (x) != VOIDmode, and abort () otherwise.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me