This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [3.0.1 and mainline] PATCH for libstdc++/3284
- To: rittle at labs dot mot dot com
- Subject: Re: [3.0.1 and mainline] PATCH for libstdc++/3284
- From: Alexandre Oliva <aoliva at redhat dot com>
- Date: 02 Jul 2001 19:56:17 -0300
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Organization: GCC Team, Red Hat
- References: <200107022232.f62MWXW23497@latour.rsch.comm.mot.com>
On Jul 2, 2001, Loren James Rittle <rittle@latour.rsch.comm.mot.com> wrote:
> ! AC_OUTPUT_COMMANDS([d=include/bits; a='[ABCDEFGHIJKLMNOPQRSTUVWXYZ_]'
> rm -f $d/gthr.h $d/gthr-single.h $d/gthr-default.h
> ! sed '/^#/s/\('$a$a'*\)/_GLIBCPP_\1/g' <$d/gthr.h-in \
I'm afraid this is not good enough. The presence of an unquoted
[ABCDE..._] will cause the shell to look for files named /^#/s/\(
followed by two capital letters or underscores, and then
*\)/_GLIBCPP_\1/g. Of course, nobody would have a file named like
that, but why take the risk? Please enclose $a in double quotes.
Similarly for the other occurrences of it.
Thanks for taking care of the problem!
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me