This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Dataflow Analysis patches
- To: Mark Mitchell <mark at codesourcery dot com>
- Subject: Re: Dataflow Analysis patches
- From: law at redhat dot com
- Date: Fri, 29 Jun 2001 08:10:15 -0700
- cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Reply-To: law at redhat dot com
In message <24720000.993785013@warlock.codesourcery.com>you write:
>
>
> --On Thursday, June 28, 2001 03:08:14 PM -0700 "law@redhat.com"
> <law@redhat.com> wrote:
>
> >
> > Attached are Michael Hayes's dataflow analysis routines. At the current
>
> The code looks clean, but the documentation needs some work. There
> are a lot of macros/routines with undocumented parameters, and some cases
> where the names of the parameters are commented in little-case instead
> of upper-case. The replace_regs structure should document its use
> and the use of its fields.
>
> Bad news: you're on the hook to fix it up, since you checked it in. :-)
Sounds fair to me. Will do.
jeff