This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: basics of flow based jump pass
- To: Jan Hubicka <jh at suse dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "rth at cygnus dot com" <rth at cygnus dot com>, "patches at x86-64 dot org" <patches at x86-64 dot org>
- Subject: Re: basics of flow based jump pass
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Wed, 27 Jun 2001 17:39:22 -0700
--On Thursday, June 28, 2001 12:18:32 AM +0200 Jan Hubicka <jh@suse.cz>
wrote:
>
> Hi,
> This patch is probably not quite complette yet, but it is the base
> of replacement of jump pass by CFG transformations.
Good.
I don't have time to review the entire patch, but a few cursory
comments:
- All functions need documentation for all parameters and return values.
- You should use `bool' for booleans; it looks like some functions
return `int' instead.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com