This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: basics of flow based jump pass




--On Thursday, June 28, 2001 12:18:32 AM +0200 Jan Hubicka <jh@suse.cz> 
wrote:

>
> Hi,
> This patch is probably not quite complette yet, but it is the base
> of replacement of jump pass by CFG transformations.

Good.

I don't have time to review the entire patch, but a few cursory
comments:

  - All functions need documentation for all parameters and return values.

  - You should use `bool' for booleans; it looks like some functions
    return `int' instead.

-- 
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]