This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: Fix location for pic register save on trunk


> Oh, why did I ever change this code?  Can I suggest this slightly cleaner
> variation which avoids the {push,pop}_topmost_sequence in most cases?
> hppa-linux-gcc has been using this (minus your comment) for quite a
> while.

Looks fine to me although I haven't tested it.  I was wondering about
the necessity of the {push,pop} myself.  There are subtle issues with
this code regarding the inlining of functions.  I suppose you have been
following this thread <http://gcc.gnu.org/ml/gcc/2001-06/msg01150.html>.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]