This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: small emit_case_nodes tweek

To: Jan Hubicka <jh at suse dot cz>
Subject: Re: small emit_case_nodes tweek
From: Alexandre Oliva <oliva at lsd dot ic dot unicamp dot br>
Date: 14 Jun 2001 08:28:35 -0300
Cc: gcc-patches at gcc dot gnu dot org, rth at cygnus dot com, patches at x86-64 dot org
References: <20010614131648.I25388@atrey.karlin.mff.cuni.cz><org0d32tjs.fsf@guarana.lsd.ic.unicamp.br>

On Jun 14, 2001, Alexandre Oliva <aoliva@redhat.com> wrote:

> On Jun 14, 2001, Jan Hubicka <jh@suse.cz> wrote:
>> + 	      /* Instead of doing two branches emit test (index-low) <= (high-low).  */
> [snip]
>> + 	      emit_cmp_and_jump_insns (new_index,
>> + 				       expand_expr (new_bound, NULL_RTX,
>> + 						    VOIDmode, 0),
>> + 				       GT, NULL_RTX, mode, 1, 0,

> Shouldn't this be GTU?  Think of low == INT_MIN and high == INT_MAX,
> for example.

Never mind.  I've just realized the `1' in the same line requests an
unsigned cmp.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

References:
- small emit_case_nodes tweek
  - From: Jan Hubicka
- Re: small emit_case_nodes tweek
  - From: Alexandre Oliva

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]