This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH [v4]: Support the FreeBSD 5.0 system thread library model



>> + 	if test x${thread_file} = xposix; then
>> + 	  if test x${enable_libgcj} = xyes; then

> What's wrong with [ test ... && test ...  ]?

Absolutely nothing AFAIK.  I just followed existing convention in
gcc/config.gcc which contains use of neither `test [...] -a [...]'
nor `&&'.  It did already contain the exact idiom I used (e.g. see
configuration fragment for solaris2).  When committing obvious patches
which have only been tested on one platform, I attempt to follow
existing convention to a tee for fear of breaking something. ;-)

Regards,
Loren


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]